Update score form input type.

Commit
fa67785624240efd9f47dc488032d3a2ce41ae6f
Author
Marius Peter <marius.peter@tutanota.com>
Author date
Committer
Marius Peter <marius.peter@tutanota.com>
Committer date
Changed files
app/views/scores/_form.html.erb
index 9cbcec7f..87a924ed 100644..100644
@@ -5,10 +5,11 @@
5 5 <% criteria.each do |criterium| %>
6 6 <% current_score = existing_scores.find { |score| score.scoring_criterium_id == criterium.id } %>
7 7 <p>
8 Removed: <%= select_tag "scores[#{criterium.id}][value]",
9 Removed: options_for_select(1..5, current_score&.value),
10 Removed: required: true,
11 Removed: prompt: "Score" %>
8 Added: <%= number_field_tag "scores[#{criterium.id}][value]",
9 Added: current_score&.value,
10 Added: in: 1..5,
11 Added: required: true,
12 Added: placeholder: "Score (1-5)" %>
12 13 <%= label_tag "scores[#{criterium.id}][value]",
13 14 criterium.name.capitalize %>
14 15 </p>
test/controllers/scores_controller_test.rb
index 6a6bc9a5..244c07cd 100644..100644
@@ -11,7 +11,7 @@
11 11 get new_tartiflette_score_path(@tartiflette)
12 12 assert_response :success
13 13 assert_select "form"
14 Removed: assert_select "select[name=?]", "scores[#{@criterium.id}][value]"
14 Added: assert_select "input[type=number][name=?]", "scores[#{@criterium.id}][value]"
15 15 end
16 16
17 17 test "should not create scores with invalid data" do
@@ -27,7 +27,7 @@
27 27 get tartiflette_edit_scores_path(@tartiflette)
28 28 assert_response :success
29 29 assert_select "form"
30 Removed: assert_select "select[name=?]", "scores[#{@criterium.id}][value]"
30 Added: assert_select "input[type=number][name=?]", "scores[#{@criterium.id}][value]"
31 31 end
32 32
33 33 test "should update scores for tartiflette" do