[Pharo] Personal fitness tracker web app.
Fix code critiques.
Changed files
- src/MyFitnessTracker-Tests/MFTWeightTest.class.st
- src/MyFitnessTracker-Tests/MFTWorkoutTest.class.st
- src/MyFitnessTracker/MFTExerciseDialog.class.st
- src/MyFitnessTracker/MFTRootComponent.class.st
- src/MyFitnessTracker/MFTScreenComponent.class.st
- src/MyFitnessTracker/MFTUser.class.st
- src/MyFitnessTracker/MFTWorkout.class.st
src/MyFitnessTracker-Tests/MFTWeightTest.class.st
@@ -6,18 +6,20 @@
6
6
7
7
{ #category : #tests }
8
8
MFTWeightTest >> testWeightIsCreatedCorrectlyBirthday [
9
Added:
9
10
| weight |
10
11
weight := MFTWeight date: (Date fromString: '06/14/1996').
11
12
weight value: 90.5.
12
13
self assert: weight date equals: (Date fromString: '06/14/1996').
13
Removed:
self assert: weight value equals: 90.5.
14
Added:
self assert: weight value equals: 90.5
14
15
]
15
16
16
17
{ #category : #tests }
17
18
MFTWeightTest >> testWeightIsCreatedCorrectlyToday [
19
Added:
18
20
| weight |
19
21
weight := MFTWeight new.
20
22
weight value: 90.0.
21
23
self assert: weight date equals: Date today.
22
Removed:
self assert: weight value equals: 90.0.
24
Added:
self assert: weight value equals: 90.0
23
25
]
src/MyFitnessTracker-Tests/MFTWorkoutTest.class.st
@@ -59,9 +59,10 @@
59
59
60
60
{ #category : #tests }
61
61
MFTWorkoutTest >> testWorkoutIsCreatedCorrectly [
62
Added:
62
63
| workout |
63
64
workout := MFTWorkout new.
64
Removed:
self assert: workout date equals: Date today.
65
Added:
self assert: workout date equals: Date today
65
66
]
66
67
67
68
{ #category : #tests }
src/MyFitnessTracker/MFTExerciseDialog.class.st
@@ -9,9 +9,6 @@
9
9
'exercise',
10
10
'sets'
11
11
],
12
Removed:
#classInstVars : [
13
Removed:
'exercise'
14
Removed:
],
15
12
#category : #'MyFitnessTracker-Dialogs'
16
13
}
17
14
src/MyFitnessTracker/MFTRootComponent.class.st
@@ -2,8 +2,7 @@
2
2
#name : #MFTRootComponent,
3
3
#superclass : #SBSRootComponent,
4
4
#instVars : [
5
Removed:
'main',
6
Removed:
'connection'
5
Added:
'main'
7
6
],
8
7
#category : #'MyFitnessTracker-Components'
9
8
}
src/MyFitnessTracker/MFTScreenComponent.class.st
@@ -4,8 +4,7 @@
4
4
#instVars : [
5
5
'header',
6
6
'footer',
7
Removed:
'mainTabs',
8
Removed:
'workoutsList'
7
Added:
'mainTabs'
9
8
],
10
9
#category : #'MyFitnessTracker-Components'
11
10
}
src/MyFitnessTracker/MFTUser.class.st
@@ -10,9 +10,6 @@
10
10
'lastConnectionDateTime',
11
11
'isLoggedIn'
12
12
],
13
Removed:
#classInstVars : [
14
Removed:
'isRegistered'
15
Removed:
],
16
13
#category : #'MyFitnessTracker-Model'
17
14
}
18
15
src/MyFitnessTracker/MFTWorkout.class.st
@@ -80,7 +80,7 @@
80
80
"Delete me"
81
81
82
82
^ self
83
Removed:
primaryMuscle: MFTMuscle chest;
83
Added:
primaryMuscle: MFTMuscleGroup chest;
84
84
exercises: {
85
85
(MFTExercise cableRow sets: {
86
86
(MFTSet reps: 8 rpe: 6).