[OCaml] High Intensity Training Online
feat drop the redundant workout fieldset legend
The stimulus form's legend restated the exercise already shown in the panel heading above it. Remove the legend; the h2 names the exercise.
Changed files
ENHANCEMENTS.org
@@ -13,7 +13,7 @@
13
13
Do not show a hamburger menu on mobile.
14
14
** DONE Add placeholders to load and reps fields
15
15
Add placeholder values to the load and reps fields on the workout logging page.
16
Removed:
** TODO Remove the redundant fieldset legend
16
Added:
** DONE Remove the redundant fieldset legend
17
17
Remove the redundant fieldset legend from workout logging.
18
18
** TODO Add animations to routine accordions
19
19
Add animations to the routine accordions.
@@ -21,3 +21,5 @@
21
21
Style the workout accordions with CSS.
22
22
** TODO Use brass for secondary buttons
23
23
Use a secondary brass color for secondary buttons.
24
Added:
** TODO Replace history with a logbook endpoint
25
Added:
Replace the history endpoint with a logbook endpoint that shows all recorded evidence for the user.
lib/web/pages.ml
@@ -552,8 +552,7 @@
552
552
[
553
553
Dream_html.csrf_tag request;
554
554
tag "fieldset" []
555
Removed:
([ tag "legend" [] [ txt "%s" (describe_prescription prescription) ] ]
556
Removed:
@ fields
555
Added:
(fields
557
556
@ [
558
557
tag "label"
559
558
[ Dream_html.string_attr "for" "%s" (field_id "extension") ]
test/test_web.ml
@@ -491,7 +491,10 @@
491
491
(contains ~substring:"placeholder=\"kg\"" page);
492
492
Alcotest.(check bool)
493
493
"hints the reps field" true
494
Removed:
(contains ~substring:"placeholder=\"reps\"" page) );
494
Added:
(contains ~substring:"placeholder=\"reps\"" page);
495
Added:
Alcotest.(check bool)
496
Added:
"drops the redundant fieldset legend" false
497
Added:
(contains ~substring:"<legend>" page) );
495
498
( "a recorded slot can be corrected, replacing it rather than adding \
496
499
volume",
497
500
`Quick,